doc: remove redundant only #14858
Closed
doc: remove redundant only #14858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
mscdex
reviewed
Aug 16, 2017
doc/api/stream.md
Outdated
| @@ -1448,8 +1448,8 @@ added: v8.0.0 | |||
| argument) when you are done writing any remaining data. | |||
|
|
|||
| Note: `_final()` **must not** be called directly. It MAY be implemented | |||
| by child classes, and if so, will be called by the internal Writable | |||
| class methods only. | |||
| by child classes, and if so, will be called by the internal Writable class | |||
There was a problem hiding this comment.
Unrelated/unnecessary change?
There was a problem hiding this comment.
Should I remove it?
There was a problem hiding this comment.
@GeorgeSapkin Yes, please. We like to keep diffs as small as possible as long as there is no noticeable benefit of having such changes.
|
LGTM |
evanlucas
approved these changes
Aug 16, 2017
hiroppy
approved these changes
Aug 16, 2017
tniessen
approved these changes
Aug 16, 2017
vsemozhetbyt
approved these changes
Aug 16, 2017
jasnell
approved these changes
Aug 16, 2017
|
Landed in 4cff2cc! 🎉 Thank you for your first contribution! |
tniessen
pushed a commit
that referenced
this pull request
Aug 20, 2017
PR-URL: #14858 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
PR-URL: #14858 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
PR-URL: #14858 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc